#hlint

Today, mostly just cleaned a lot of (h)lint out of Phaestus (lots of unnecessary parentheses removed), but I also rewrote some of the subparsers to return strings instead of single chars or voids, in case I ever decide I want to capture the actual text recognized for some reason. Reorganized some code for better readability; also moved most of the subparsers out of the top-level of the Tokenizer.hs file (mostly to shut up HLint because I don't have type declarations on all of them, lazy me).

I especially think rewriting

optional (PC.char 'b') >> (PC.string "???") >> tabsAndSpaces >> (ident <|> (between (PC.char '\'') (PC.char '\'') ident) <|> (between (PC.char '"') (PC.char '"') ident)) >> nl

as

do bflag <- optionMaybe (PC.char 'b') _ <- PC.string ">>>" _ <- tabsAndSpaces lbl <- ident <|> between (PC.char '\'') (PC.char '\'') ident <|> between (PC.char '"') (PC.char '"') ident _ <- nl

Despite feeling fairly miserable today, I did manage to take my Minecraft Anvil reader library and whip it into a basic Haskell package and publish it on github. HLint complained quite a lot about my code, which isn't really surprising since this code was started when I was still fairly neophytic at Haskell. The published version doesn't attempt to interpret the chunk data yet. I have code that does some of that, but moving that into the library is for another day, to say nothing of writing the rest of it.

Aside from not parsing chunk data, there's one thing about this code that I want to address at some point. In Minecraft, NBT lists are homogenous. In my code, I represented an NBT list as [NBT], but this doesn't actually enforce homogenity as NBT is an algebraic data type that encompasses all NBT types. What I need to do is make this something like NBTListable a => NBTList a where NBTListable has as, instances, each of the types that can appear in a NBT list, but I haven't quite figured out how to do this. So that will probably happen in the near future.